Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realign pages to link to release assets #28

Merged

Conversation

nikitawootten-nist
Copy link
Collaborator

@nikitawootten-nist nikitawootten-nist commented Aug 1, 2023

This PR addresses #27 utilizing meta-redirects to release assets generated as part of usnistgov/OSCAL-Reference#2.

It also updates wording on the release tutorial tool page

NOTE: this change depends on the following conditions:

@nikitawootten-nist nikitawootten-nist changed the base branch from main to develop August 1, 2023 21:33
@nikitawootten-nist nikitawootten-nist changed the title Realign pages to link to release assets [DO NOT MERGE] Realign pages to link to release assets Aug 1, 2023
@nikitawootten-nist nikitawootten-nist changed the title [DO NOT MERGE] Realign pages to link to release assets Realign pages to link to release assets Aug 3, 2023
Copy link
Collaborator Author

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review: I've tested that the new links in the reference work.

src/content/learn/tutorials/general/releases.md Outdated Show resolved Hide resolved
src/content/learn/tutorials/general/releases.md Outdated Show resolved Hide resolved
src/content/learn/tutorials/general/releases.md Outdated Show resolved Hide resolved
src/content/learn/tutorials/general/releases.md Outdated Show resolved Hide resolved
src/content/tools/_index.md Show resolved Hide resolved
src/content/tools/_index.md Outdated Show resolved Hide resolved
src/content/tools/_index.md Outdated Show resolved Hide resolved
Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All broken links identified by #27 in the following files work:
[x] ./src/content/concepts/layer/assessment/assessment-plan/_index.md
[x] ./src/content/concepts/layer/assessment/assessment-results/_index.md
[x] ./src/content/concepts/layer/assessment/poam/_index.md
[x] ./src/content/concepts/layer/control/catalog/_index.md
[x] ./src/content/concepts/layer/control/profile/_index.md
[x] ./src/content/concepts/layer/implementation/component-definition/_index.md
[x] ./src/content/concepts/layer/implementation/ssp/_index.md
[x] ./src/content/concepts/layer/overview.md
[x] ./src/content/learn/tutorials/general/releases.md
[x] ./src/content/tools/_index.md
Others:
[x] ./src/content/concepts/layer/_index.md

@aj-stein-nist aj-stein-nist merged commit 6bb0d12 into usnistgov:develop Aug 29, 2023
4 checks passed
Arminta-Jenkins-NIST pushed a commit that referenced this pull request Sep 12, 2023
* Realign pages to link to release assets (#27)

* Apply suggestions from code review

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>

---------

Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants